Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added method to set custom subtitle #1581

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Fruchtzwerg94
Copy link
Contributor

  • Allows to set a custom subtitle like done with the title as well
  • Uses AP name and IP as fallback like done before
  • Fixes @todo use hostname?

@Fruchtzwerg94 Fruchtzwerg94 changed the title Added method to set custom sub title Added method to set custom subtitle Apr 6, 2023
@ab-tools
Copy link

ab-tools commented Jan 1, 2024

Was looking for the same, would appreciate if this gets merged, thanks.

@ab-tools
Copy link

ab-tools commented Jan 1, 2024

Note that in the pull request from @Fruchtzwerg94 the sub title replace on the update page is missing here:
https://github.com/tzapu/WiFiManager/blob/master/WiFiManager.cpp#L3873
and here:
https://github.com/tzapu/WiFiManager/blob/master/WiFiManager.cpp#L3983

Maybe @Fruchtzwerg94 still wants to add it to this pull request.

@Fruchtzwerg94
Copy link
Contributor Author

Good hint @ab-tools ,
I've merged the latest changes of the master to the branch and added the subtitle to the proposed sites as well.
BR

@ab-tools
Copy link

ab-tools commented Jan 1, 2024

Great, thanks, Philipp!

Looking forward to have this merged soon, so I can switch back to the main repository.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants